Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin fines datatable page #2533

Closed
wants to merge 19 commits into from
Closed

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Nov 26, 2018

Closing in favor of #2639

Summary

How to test

  1. vi ~/.bash_profile and insert this feature flag for ADRs export FEC_FEATURE_AFS=true
  2. Open a new terminal window and run the branch
  3. Go to http://localhost:8000/data/legal/search/admin_fines/ to test the page. At this point, none of the canonical Admin fine links will work since that is phase 2 of the development for this feature.

Impacted areas of the application

List general components of the application that this PR will affect:

  • Enforcement Admin fines datatable page

Screenshots

screen shot 2018-11-26 at 8 20 35 am

@patphongs patphongs changed the title [WIP] Admin fines datatable page [Do not merge yet] Admin fines datatable page Nov 26, 2018
@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #2533 into develop will decrease coverage by 0.16%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2533      +/-   ##
==========================================
- Coverage    75.07%   74.9%   -0.17%     
==========================================
  Files          116     116              
  Lines         6977    6990      +13     
  Branches       599     599              
==========================================
- Hits          5238    5236       -2     
- Misses        1739    1754      +15
Impacted Files Coverage Δ
fec/fec/settings/base.py 87.5% <ø> (ø) ⬆️
fec/legal/views.py 50% <11.11%> (-4.55%) ⬇️
fec/legal/urls.py 75% <50%> (-8.34%) ⬇️
fec/data/api_caller.py 30.56% <66.66%> (+0.17%) ⬆️
fec/fec/static/js/modules/toc.js 87.17% <0%> (-10.26%) ⬇️
fec/data/views.py 47.7% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8d6c2...c35e5e8. Read the comment docs.

@patphongs patphongs changed the title [Do not merge yet] Admin fines datatable page Admin fines datatable page Dec 7, 2018
@lbeaufort lbeaufort changed the title Admin fines datatable page [Awaiting external review] Admin fines datatable page Dec 14, 2018
@lbeaufort lbeaufort changed the title [Awaiting external review] Admin fines datatable page Admin fines datatable page Dec 17, 2018
Copy link
Member

@lbeaufort lbeaufort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @patphongs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants