-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MERGE WITH GIT FLOW] Change addresses/text changes on contact page #1868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @johnnyporkchops - looks great, just two questions about commas.
@@ -109,7 +109,7 @@ | |||
</li> | |||
</ul> | |||
|
|||
<p>999 E Street, NW<br> | |||
<p>1050 First Street NE<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a comma? 1050 First Street, NE
fec/fec/templates/base.html
Outdated
@@ -126,7 +126,7 @@ <h2 style="color: #ffffff">Your browser is outdated</h2> | |||
</li> | |||
</ul> | |||
|
|||
<p>999 E Street, NW<br> | |||
<p>1050 First Street NE<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above- should this have a comma before NE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1050 First Street, NE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I copied and pasted form the spreadsheet where there is no comma.https://docs.google.com/spreadsheets/d/1xCH8wriV3Vh0eCN-1wIVhtjlltEK-BqDFJOI9nX0gvI/edit#gid=0
Codecov Report
@@ Coverage Diff @@
## master #1868 +/- ##
=======================================
Coverage 79.39% 79.39%
=======================================
Files 45 45
Lines 3261 3261
Branches 488 488
=======================================
Hits 2589 2589
Misses 672 672 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @johnnyporkchops!
Change address on home and data footers and make ext changes to contact page.
Addresses: Hardcoded changes for FEC address #1848
Contact page:
Home footer:
Data footer: