Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE WITH GIT FLOW] Change addresses/text changes on contact page #1868

Merged
merged 2 commits into from
Mar 19, 2018

Conversation

johnnyporkchops
Copy link
Contributor

Change address on home and data footers and make ext changes to contact page.
Addresses: Hardcoded changes for FEC address #1848

Contact page:

contact

Home footer:

home_footer

Data footer:

data_footer

Copy link
Member

@lbeaufort lbeaufort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnnyporkchops - looks great, just two questions about commas.

@@ -109,7 +109,7 @@
</li>
</ul>

<p>999 E Street, NW<br>
<p>1050 First Street NE<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a comma? 1050 First Street, NE

@@ -126,7 +126,7 @@ <h2 style="color: #ffffff">Your browser is outdated</h2>
</li>
</ul>

<p>999 E Street, NW<br>
<p>1050 First Street NE<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above- should this have a comma before NE?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1050 First Street, NE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I copied and pasted form the spreadsheet where there is no comma.https://docs.google.com/spreadsheets/d/1xCH8wriV3Vh0eCN-1wIVhtjlltEK-BqDFJOI9nX0gvI/edit#gid=0

@codecov-io
Copy link

Codecov Report

Merging #1868 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1868   +/-   ##
=======================================
  Coverage   79.39%   79.39%           
=======================================
  Files          45       45           
  Lines        3261     3261           
  Branches      488      488           
=======================================
  Hits         2589     2589           
  Misses        672      672

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb7fbc...e3e1e3e. Read the comment docs.

Copy link
Member

@lbeaufort lbeaufort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @johnnyporkchops!

@lbeaufort lbeaufort merged commit e3e1e3e into master Mar 19, 2018
@lbeaufort lbeaufort deleted the hotfix/change-address-contact-page branch August 21, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants