Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded changes for FEC address #1848

Closed
4 tasks done
Tracked by #113
AmyKort opened this issue Mar 9, 2018 · 3 comments
Closed
4 tasks done
Tracked by #113

Hardcoded changes for FEC address #1848

AmyKort opened this issue Mar 9, 2018 · 3 comments
Assignees
Labels
HOTFIX Merge with git flow Work: Front-end
Milestone

Comments

@AmyKort
Copy link

AmyKort commented Mar 9, 2018

When we change the FEC address on the contact page https://github.com/18f/fec-cms/issues/1723, we should also make a few changes to the office descriptions.

  • Information Division description should read "Including help with campaign finance law, educational materials or registration and reporting forms"
  • Press Office description should read "Including press queries and inquiries about Commission meetings"
  • Change mailing address to "1050 First Street, NE"

We also need to:

  • Change the address on the bottom banner to 1050 First Street, NE (three versions of the banner)

This will need a hotfix on Monday the 19th.

@AmyKort AmyKort modified the milestones: Sprint 5.3, Sprint 5.2 Mar 9, 2018
@AmyKort AmyKort added the HOTFIX Merge with git flow label Mar 15, 2018
@dorothyyeager
Copy link
Contributor

dorothyyeager commented Mar 15, 2018

Just wanted to leave the spreadsheet of places needing the address change here too, in case there are other hard-coded pages that need it. Wagtail changes are addressed in #1723 .

https://docs.google.com/spreadsheets/d/1xCH8wriV3Vh0eCN-1wIVhtjlltEK-BqDFJOI9nX0gvI/edit#gid=0

@AmyKort AmyKort changed the title Changes to descriptions on Contact page Hardcoded changes for FEC address Mar 15, 2018
@patphongs
Copy link
Member

patphongs commented Mar 16, 2018

Transition site address changes have been completed.

Along with updating the transition footer, I did a replacement for 4 different variations of our old address below. To help save time with manual updates in the transition content pages.

999 E Street, N.W.
999 E Street, Northwest
999 E Street, NW
999 E Street NW

This does NOT account for any Room numbers that need to be updated. And it’s possible some other pattern variations were missed, but my hope is that it covered the majority.

This resulted in 139 HTM, HTML, and SHTML files being updated.

I cross checked with the 31 identified files in the attached spreadsheet to this ticket and it seems to have replaced all of those too.

@lbeaufort
Copy link
Member

Deployed, thanks @johnnyporkchops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HOTFIX Merge with git flow Work: Front-end
Projects
None yet
Development

No branches or pull requests

5 participants