Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This change makes RFAI inclusive for all request types #1835

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Mar 6, 2018

Summary

Committees filing page:

http://localhost:8000/data/committee/C00659672/?tab=filings

Regularly filed reports table:

  • RQ-2: RFAI referencing Report of Receipts and Expenditures
  • RQ-3: RFAI referencing second notice reports
  • RQ-4: RFAI referencing Independent Expenditure filer
  • RQ-7: RFAI referencing failure to file
  • RQ-8: RFAI referencing public disclosure

Statement of organization table:

  • RQ-1: RFAI referencing Statement of organization
  • RQ-6: RFAI referencing 2nd notice State of organization

Other documents table:

  • RQ-9: RFAI referencing Multicandidate status

Candidate about page:

http://localhost:8000/data/candidate/H8AR04122/?tab=about-candidate

Other documents table:

  • RQ-5: RFAI referencing Statement of Candidacy

Impacted areas of the application

List general components of the application that this PR will affect:

  • Candidate profile page: About tab
  • Committee profile page: Filings tab

Related PRs

List related PRs against other branches:

PR #1826

@patphongs patphongs requested a review from lbeaufort March 6, 2018 16:20
@patphongs patphongs changed the title This change makes RFAI inclusive for all request types. This change makes RFAI inclusive for all request types Mar 6, 2018
@patphongs patphongs requested a review from llienfec March 6, 2018 17:45
Copy link
Contributor

@llienfec llienfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFAI types look like they're in the right places. Good job @patphongs!

@patphongs patphongs added this to the Sprint 5.2 milestone Mar 6, 2018
@@ -208,7 +208,11 @@ function initOtherDocumentsTable() {
query: {
candidate_id: candidateId,
form_type: ['F99','RFAI'],
//exclude all request types except for RQ-5: RFAI referencing Statement of Candidacy
/* Performing an include would only show RFAI form types. For this reason, excludes need to be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment here!

@lbeaufort lbeaufort merged commit 789500e into develop Mar 7, 2018
@lbeaufort lbeaufort deleted the feature/1760-update-rfai-table branch March 7, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants