Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP - Don't merge yet] Fixed RFAIs that reference Form 1 #1706

Closed
wants to merge 2 commits into from

Conversation

patphongs
Copy link
Member

Summary

  • Addresses https://github.com/18F/fec-cms/issues/1663
    RFAI's that reference a statement of organization, also known as RQ2, was not showing in the filings table. The problem was that nulls were being filtered out from the regularly filed reports. Now that null values are shown, we can now see all the RFAI's within the Regularly filed reports section of the committee's filing tab

Note: It was requested that we group the RFAIs that reference form 1 with the statement of organization. However, after reviewing the code, it is a lot more difficult to implement this given the current abilities of our API. A possible easier solution would be to refactor the RFAIs to their own section that is separate from the Regularly filed reports section.

Impacted areas of the application

List general components of the application that this PR will affect:

  • Committee's filing tab

Screenshots

Below is an example with all the RFAIs shown for committee ID C00637983
screen shot 2018-01-17 at 3 08 57 pm

@patphongs patphongs changed the title Fixed RFAIs that reference Form 1 [WIP - Don't merge yet] Fixed RFAIs that reference Form 1 Jan 18, 2018
@bmathesonFEC
Copy link
Contributor

@patphongs Just to confirm, there's no way to select a NULL or NA value? Similarly, is there no way to exclude (<>) criteria in an API call, right? I'm asking because I think this could get us the results we need:
(form_type = F1 OR form_type = RFAI) AND report_type = NA

(Sorry to ask questions you've probably already asked and answered)

@patphongs
Copy link
Member Author

@bmathesonFEC Good question! We can show nulls, however, there's no way to show nulls of only a specific form_type or report_type right now. The easiest way would be for the data to be cleaned up. Right now any request_type = RQ1 has a null form_type. If we can populate the form_type for RQ1's to be form_type=F1, then the Form 1 RFAIs will show up. Still trying to see how the form_type gets populated, as RQ2s seem to have a form type, just not RQ1s.

@patphongs
Copy link
Member Author

Closing this issue, exclude logic has been added to the API capabilities and this PR is now old and was replaced by this PR: #1835

@patphongs patphongs closed this Mar 13, 2018
@lbeaufort lbeaufort deleted the feature/1663-rfai-soo-fix branch September 13, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants