Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presidential candidate raising breakdown not consistent with adv. data table #1949

Closed
2 tasks
JonellaCulmer opened this issue Apr 25, 2018 · 8 comments
Closed
2 tasks
Assignees
Milestone

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Apr 25, 2018

What we're after: Presidential candidate Raising overview bar chart does not reflect all candidates currently raising funds for 2020. The data is filtered by two-year period, with the latest showing as 2017-2018. There should at least be some overlap with the information presented on the Presidential candidates advanced data table.

screen shot 2018-04-25 at 11 45 58 am

The data included on the Presidential candidates advanced data table is from 2017-2020, which includes 2017-2018. Additionally, the presidential candidate listed on the Raising breakdown is not on the list of Presidential candidates for 2017-2020.

screen shot 2018-04-25 at 11 46 27 am

Relevant issue: #1950 and #2007

Completion:

  • Show 2020 in pulldown
  • don't break anything else
@jwchumley
Copy link

jwchumley commented Apr 25, 2018

@JonellaCulmer
When you say this is not the list of pres candidates for 2017-2020, what list are you comparing this to?

@PaulClark2
Copy link
Contributor

Clark's Form 2 has issues. She's indicated her election year is 2018. There's no presidential election in 2018.

I think there's a general problem with the drop down for presidential. 2017-2018 shouldn't be an option. For presidential, the options should be 2012, 2016 and 20202. The start year of those options depends on if the raising and spending bread down's are pulling two-year period data or if they are pulling four-year period data.

@jwchumley
Copy link

What Paul said.

@JonellaCulmer
Copy link
Contributor Author

Okay, thanks. So is this work essentially the same or similar to work done in #1945, Add missing cycles to raising/spending breakdowns?

@lbeaufort
Copy link
Member

lbeaufort commented Apr 25, 2018

@JonellaCulmer - the change would be pretty different from my PR because if you want the cycle options to dynamically change depending on the office sought, that's a JavaScript change and the dropdowns are currently hard-coded. The initial issue says "Include all 2 year periods even for presidential and Senate candidates" but I agree that it would be better if the cycles were dynamic.

@AmyKort
Copy link

AmyKort commented May 25, 2018

Is this something that needs to wait for #2007 or that should be completed in tandem with it?

@jwchumley
Copy link

@AmyKort I think tandem but whoever does the work may change that once they start digging into it.

@lbeaufort
Copy link
Member

Combining with fecgov/openFEC#3214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants