Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presidential 2017 - 2020 data on adv data table not displaying properly #3214

Closed
1 task
lbeaufort opened this issue Jun 15, 2018 · 3 comments · Fixed by #3219
Closed
1 task

Presidential 2017 - 2020 data on adv data table not displaying properly #3214

lbeaufort opened this issue Jun 15, 2018 · 3 comments · Fixed by #3219
Assignees
Milestone

Comments

@lbeaufort
Copy link
Member

@JonellaCulmer commented on Wed Apr 25 2018

Relevant issue: #1949

What we're after: The Presidential candidates advanced data table is not displaying data for the two-year periods within the 4-year presidential cycle. When viewing 2017-2020 data, we get a full list of candidates currently raising and spending money for the 2020 election. However, upon filtering to view 2017-2018 data, the tables are empty. We need to display data by both 2017-2020 and by two-year periods.

Completion:

  • Identify desired interaction for buttons

screen shot 2018-04-25 at 11 53 53 am

screen shot 2018-04-25 at 11 55 06 am


@AmyKort commented on Fri May 25 2018

Is this something that will be dependent on fecgov/fec-cms#2007 ?

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Jun 18, 2018

There appears to be a similar issue happening with the Senate candidates datatable as well as the Senate table is also pulling from the candidate/totals endpoint. Using inspect and viewing the API call, if I remove the cycle and election-year data populates, beyond that I'm not able to pinpoint the cause.

Perhaps your fix will also help in some way with this data as well? I'm happy to pair on this for however long.
https://www.fec.gov/data/candidates/senate/?election_year=2020&cycle=2020&election_full=false

@lbeaufort
Copy link
Member Author

Thanks for your research, @JonellaCulmer! The fix should address candidate totals for candidates who have declared for future election cycles - house/senate/presidential. I'm still in the process of testing, though.

@JonellaCulmer
Copy link
Contributor

@lbeaufort House candidates look to be about the same as Senate and Presidential, excluding the "All years" option, which is not utilized on this table.

Although, for House candidates, we do have candidates registered for elections up until 2028. I'm not confident we need to list elections out that far in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants