Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge please] Add missing cycles to raising/spending breakdowns #1945

Closed
wants to merge 1 commit into from

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Apr 24, 2018

Summary (required)

Impacted areas of the application

Screenshots

Before

Raising

screen shot 2018-04-25 at 10 03 54 am

Spending

screen shot 2018-04-25 at 10 03 34 am

After

Raising

screen shot 2018-04-25 at 10 02 59 am

Spending

screen shot 2018-04-25 at 10 03 16 am

@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #1945 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1945   +/-   ##
========================================
  Coverage    79.26%   79.26%           
========================================
  Files           45       45           
  Lines         3275     3275           
  Branches       489      489           
========================================
  Hits          2596     2596           
  Misses         679      679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f4f7d...fb2e90a. Read the comment docs.

@lbeaufort lbeaufort force-pushed the feature/update-raising-spending-pages branch from b1e7f46 to fb2e90a Compare April 25, 2018 13:50
@lbeaufort lbeaufort changed the title [WIP] Add 2014 cycle to raising/spending breakdowns Add missing cycles to raising/spending breakdowns Apr 25, 2018
@lbeaufort lbeaufort requested a review from apburnes April 25, 2018 18:28
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lbeaufort lbeaufort changed the title Add missing cycles to raising/spending breakdowns [Don't merge please] Add missing cycles to raising/spending breakdowns Apr 27, 2018
@lbeaufort
Copy link
Member Author

Closed in favor of #1958

@lbeaufort lbeaufort closed this Apr 27, 2018
@lbeaufort lbeaufort deleted the feature/update-raising-spending-pages branch August 17, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants