Increase Jaeger Tracing coverage #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
force-pushed
the
add-jaeger-logs-onlinefeatures
branch
from
8da854f to
3432576
Compare
terryyylim
force-pushed
the
add-jaeger-logs-onlinefeatures
branch
from
3432576 to
03259d9
Compare
woop
changed the title
terryyylim
force-pushed
the
add-jaeger-logs-onlinefeatures
branch
from
03259d9 to
5c70ce5
Compare
woop
approved these changes
Jun 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terryyylim, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test test-end-to-end-batch |
jmelinav
pushed a commit
to jmelinav/feast
that referenced
this pull request
Jun 4, 2020
* Add jaegertracing logs to getOnlineFeatures * Apply spotless staging client stubs strategy pattern Moving logic and adding s3 support test cases and some refactoring returning file object updated tests fixed lint error and added moto to requirements-ci
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Jun 5, 2020
* Add jaegertracing logs to getOnlineFeatures * Apply spotless
khorshuheng
pushed a commit
that referenced
this pull request
Jun 5, 2020
* Add jaegertracing logs to getOnlineFeatures * Apply spotless
zhangchi1
pushed a commit
to Cimpress-MCP/feast
that referenced
this pull request
Jun 11, 2020
* Add jaegertracing logs to getOnlineFeatures * Apply spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Helps us to debug performance bottle neck for Online Retrieval.
Does this PR introduce a user-facing change?: