Skip to content

Commit

Permalink
Increase Jaeger Tracing coverage (#719)
Browse files Browse the repository at this point in the history
* Add jaegertracing logs to getOnlineFeatures

* Apply spotless
  • Loading branch information
terryyylim authored Jun 1, 2020
1 parent f9ce8ee commit a33883f
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package feast.serving.service;

import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Maps;
import com.google.protobuf.Duration;
import feast.proto.serving.ServingAPIProto.*;
Expand Down Expand Up @@ -75,6 +76,9 @@ public GetOnlineFeaturesResponse getOnlineFeatures(GetOnlineFeaturesRequest requ
// feature set request.
List<List<FeatureRow>> featureRows =
retriever.getOnlineFeatures(entityRows, featureSetRequests);
if (scope != null) {
scope.span().log(ImmutableMap.of("event", "featureRows", "value", featureRows));
}

// For each feature set request, read the feature rows returned by the retriever, and
// populate the featureValuesMap with the feature values corresponding to that entity row.
Expand Down

0 comments on commit a33883f

Please sign in to comment.