Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tagging for snowflake engine #3147

Merged

Conversation

sfc-gh-madkins
Copy link
Collaborator

Signed-off-by: Miles Adkins [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #3147 (177dfc6) into master (20a9dd9) will decrease coverage by 8.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
- Coverage   67.11%   58.29%   -8.83%     
==========================================
  Files         175      209      +34     
  Lines       15905    17586    +1681     
==========================================
- Hits        10675    10251     -424     
- Misses       5230     7335    +2105     
Flag Coverage Δ
integrationtests ?
unittests 58.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...n/tests/integration/registration/test_inference.py 35.71% <0.00%> (-64.29%) ⬇️
... and 159 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sfc-gh-madkins sfc-gh-madkins force-pushed the snowflake_engine_tagging branch from a2c938a to 177dfc6 Compare August 28, 2022 03:30
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines 26 to +28
@vectorized(input=pandas.DataFrame)
def feast_snowflake_binary_to_bytes_proto(df):
sys._xoptions["snowflake_partner_attribution"].append("feast")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but I'm curious how the python client serializes these UDFs - is there any documentation or a place in the code you could point me to?

@feast-ci-bot feast-ci-bot merged commit 8fbf13c into feast-dev:master Aug 29, 2022
@sfc-gh-madkins sfc-gh-madkins deleted the snowflake_engine_tagging branch August 29, 2022 22:03
adchia pushed a commit that referenced this pull request Aug 31, 2022
Signed-off-by: Miles Adkins <[email protected]>

Signed-off-by: Miles Adkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants