-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add tagging for snowflake engine #3147
chore: Add tagging for snowflake engine #3147
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3147 +/- ##
==========================================
- Coverage 67.11% 58.29% -8.83%
==========================================
Files 175 209 +34
Lines 15905 17586 +1681
==========================================
- Hits 10675 10251 -424
- Misses 5230 7335 +2105
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Miles Adkins <[email protected]>
a2c938a
to
177dfc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, sfc-gh-madkins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vectorized(input=pandas.DataFrame) | ||
def feast_snowflake_binary_to_bytes_proto(df): | ||
sys._xoptions["snowflake_partner_attribution"].append("feast") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but I'm curious how the python client serializes these UDFs - is there any documentation or a place in the code you could point me to?
Signed-off-by: Miles Adkins <[email protected]> Signed-off-by: Miles Adkins <[email protected]>
Signed-off-by: Miles Adkins [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #