fix: Fix release workflow (#3144)

* Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix helm charts Signed-off-by: Kevin Zhang <[email protected]> Signed-off-by: Kevin Zhang <[email protected]>
feast-dev · Aug 25, 2022 · 20a9dd9 · 20a9dd9
1 parent 31774e2
commit 20a9dd9
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 32 deletions.
diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml
@@ -17,7 +17,10 @@ jobs:
       version_without_prefix: ${{ steps.get_release_version_without_prefix.outputs.version_without_prefix }}
       highest_semver_tag: ${{ steps.get_highest_semver.outputs.highest_semver_tag }}
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          persist-credentials: false
       - name: Get release version
         id: get_release_version
         run: echo ::set-output name=release_version::${GITHUB_REF#refs/*/}
@@ -38,6 +41,7 @@ jobs:
             echo ::set-output name=highest_semver_tag::$(get_tag_release -m)
           fi
       - name: Check output
+        id: check_output
         env:
           RELEASE_VERSION: ${{ steps.get_release_version.outputs.release_version }}
           VERSION_WITHOUT_PREFIX: ${{ steps.get_release_version_without_prefix.outputs.version_without_prefix }}

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -42,40 +42,41 @@ jobs:
           echo "Current version is ${CURRENT_VERSION}"
           echo "Next version is ${NEXT_VERSION}"
 
-  # publish-web-ui-npm:
-  #   if: github.repository == 'feast-dev/feast'
-  #   needs: get_dry_release_versions
-  #   runs-on: ubuntu-latest
-  #   env:
-  #     # This publish is working using an NPM automation token to bypass 2FA
-  #     NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-  #     CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
-  #     NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
-  #   steps:
-  #     - uses: actions/checkout@v2
-  #     - uses: actions/setup-node@v2
-  #       with:
-  #         node-version: '17.x'
-  #         registry-url: 'https://registry.npmjs.org'
-  #     - name: Bump file versions (temporarily for Web UI publish)
-  #       run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
-  #     - name: Install yarn dependencies
-  #       working-directory: ./ui
-  #       run: yarn install
-  #     - name: Build yarn rollup
-  #       working-directory: ./ui
-  #       run: yarn build:lib
-  #     - name: Publish UI package
-  #       working-directory: ./ui
-  #       run: npm publish
-  #       env:
-  #         # This publish is working using an NPM automation token to bypass 2FA
-  #         NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+  publish-web-ui-npm:
+    if: github.repository == 'feast-dev/feast'
+    needs: get_dry_release_versions
+    runs-on: ubuntu-latest
+    env:
+      # This publish is working using an NPM automation token to bypass 2FA
+      NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+      CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
+      NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2
+        with:
+          node-version: '17.x'
+          registry-url: 'https://registry.npmjs.org'
+      - name: Bump file versions (temporarily for Web UI publish)
+        run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
+      - name: Install yarn dependencies
+        working-directory: ./ui
+        run: yarn install
+      - name: Build yarn rollup
+        working-directory: ./ui
+        run: yarn build:lib
+      - name: Publish UI package
+        if: github.event.inputs.dry_run == 'false'
+        working-directory: ./ui
+        run: npm publish
+        env:
+          # This publish is working using an NPM automation token to bypass 2FA
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
 
   release:
     name: release
     runs-on: ubuntu-latest
-    #needs: publish-web-ui-npm
+    needs: publish-web-ui-npm
     env:
       GITHUB_TOKEN: ${{ github.event.inputs.token }}
       GIT_AUTHOR_NAME: feast-ci-bot

diff --git a/infra/scripts/helm/validate-helm-chart-versions.sh b/infra/scripts/helm/validate-helm-chart-versions.sh
@@ -3,7 +3,7 @@
 set -e
 
 # Amount of file locations that need to be bumped in unison when versions increment
-UNIQUE_VERSIONS_COUNT=20
+UNIQUE_VERSIONS_COUNT=21 # Change in release 0.24.0
 
 if [ $# -ne 1 ]; then
     echo "Please provide a single semver version (without a \"v\" prefix) to test the repository against, e.g 0.99.0"