Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix build wheels workflow to install apache-arrow correctly #2932

Merged
merged 18 commits into from
Jul 11, 2022
Merged

fix: Fix build wheels workflow to install apache-arrow correctly #2932

merged 18 commits into from
Jul 11, 2022

Conversation

kevjumba
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

achals
achals approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This will need corresponding doc changes, are they already in for users?

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #2932 (a20b99b) into master (292adc2) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head a20b99b differs from pull request most recent head 4eb6b4b. Consider uploading reports for the commit 4eb6b4b to get more accurate results

@@            Coverage Diff             @@
##           master    #2932      +/-   ##
==========================================
- Coverage   78.57%   78.51%   -0.06%     
==========================================
  Files         179      179              
  Lines       15877    15877              
==========================================
- Hits        12475    12466       -9     
- Misses       3402     3411       +9
Flag Coverage Δ
integrationtests 68.34% <ø> (-0.14%) ⬇️
unittests 59.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
sdk/python/tests/conftest.py 76.02% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292adc2...4eb6b4b. Read the comment docs.

kevjumba added 18 commits July 11, 2022 12:47
@kevjumba
Fix
f30a02a 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
1fd20c2 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
f2759a1 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
124084e 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
f0f1333 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
ff18a59 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
190575a 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
b5b04aa 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
56504f6 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
ef7854e 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
46ea359 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
b1bea07 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
1f848f0 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
593b696 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
0c817f7 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
fa1c0dc 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
5284774 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
4eb6b4b 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba kevjumba force-pushed the fix_build_wheels_workflow branch from a20b99b to 4eb6b4b Compare July 11, 2022 19:50
@feast-ci-bot feast-ci-bot removed the lgtm label Jul 11, 2022
achals
achals approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals achals merged commit bdeb4ae into feast-dev:master Jul 11, 2022
adchia pushed a commit that referenced this pull request Jul 14, 2022
@kevjumba @adchia
fix: Fix build wheels workflow to install apache-arrow correctly (#2932)
d45449b 
* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
kevjumba added a commit that referenced this pull request Jul 19, 2022
@kevjumba
fix: Fix build wheels workflow to install apache-arrow correctly (#2932)
4b69e0e 
* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
kevjumba pushed a commit that referenced this pull request Jul 19, 2022
@feast-ci-bot
chore(release): release 0.22.1
0bfc7d9 
## [0.22.1](v0.22.0...v0.22.1) (2022-07-19)

### Bug Fixes

* Change numpy version on setup.py and upgrade it to resolve dependabot warning ([#2887](#2887)) ([b9190b9](b9190b9))
* Change the feature store plan method to public modifier ([#2904](#2904)) ([568058a](568058a))
* Deprecate 3.7 wheels and fix verification workflow ([#2934](#2934)) ([146e36d](146e36d))
* Fix build wheels workflow to install apache-arrow correctly ([#2932](#2932)) ([4b69e0e](4b69e0e))
* Fix grpc and update protobuf ([#2894](#2894)) ([f726c96](f726c96))
* Fix night ci syntax error and update readme ([#2935](#2935)) ([b35553b](b35553b))
* Fix nightly ci again ([#2939](#2939)) ([c363619](c363619))
* Fix the go build and use CgoArrowAllocator to prevent incorrect garbage collection ([#2919](#2919)) ([f4f4894](f4f4894))
* Fixing broken links to feast documentation on java readme and contribution ([#2892](#2892)) ([a45e10a](a45e10a))
* Resolve small typo in README file ([#2930](#2930)) ([9840c1b](9840c1b))
* Update gopy to point to fork to resolve github annotation errors. ([#2940](#2940)) ([9b9fbbe](9b9fbbe))
felixwang9817 pushed a commit that referenced this pull request Aug 2, 2022
@feast-ci-bot
chore(release): release 0.23.0
48a8275 
# [0.23.0](v0.22.0...v0.23.0) (2022-08-02)

### Bug Fixes

* Add dummy alias to pull_all_from_table_or_query ([#2956](#2956)) ([5e45228](5e45228))
* Bump version of Guava to mitigate cve ([#2896](#2896)) ([51df8be](51df8be))
* Change numpy version on setup.py and upgrade it to resolve dependabot warning ([#2887](#2887)) ([80ea7a9](80ea7a9))
* Change the feature store plan method to public modifier ([#2904](#2904)) ([0ec7d1a](0ec7d1a))
* Deprecate 3.7 wheels and fix verification workflow ([#2934](#2934)) ([040c910](040c910))
* Do not allow same column to be reused in data sources ([#2965](#2965)) ([661c053](661c053))
* Fix build wheels workflow to install apache-arrow correctly ([#2932](#2932)) ([bdeb4ae](bdeb4ae))
* Fix file offline store logic for feature views without ttl ([#2971](#2971)) ([26f6b69](26f6b69))
* Fix grpc and update protobuf ([#2894](#2894)) ([86e9efd](86e9efd))
* Fix night ci syntax error and update readme ([#2935](#2935)) ([b917540](b917540))
* Fix nightly ci again ([#2939](#2939)) ([1603c9e](1603c9e))
* Fix the go build and use CgoArrowAllocator to prevent incorrect garbage collection ([#2919](#2919)) ([130746e](130746e))
* Fix typo in CONTRIBUTING.md ([#2955](#2955)) ([8534f69](8534f69))
* Fixing broken links to feast documentation on java readme and contribution ([#2892](#2892)) ([d044588](d044588))
* Fixing Spark min / max entity df event timestamps range return order ([#2735](#2735)) ([ac55ce2](ac55ce2))
* Move gcp back to 1.47.0 since grpcio-tools 1.48.0 got yanked from pypi ([#2990](#2990)) ([fc447eb](fc447eb))
* Refactor testing and sort out unit and integration tests ([#2975](#2975)) ([2680f7b](2680f7b))
* Remove hard-coded integration test setup for AWS & GCP ([#2970](#2970)) ([e4507ac](e4507ac))
* Resolve small typo in README file ([#2930](#2930)) ([16ae902](16ae902))
* Revert "feat: Add snowflake online store ([#2902](#2902))" ([#2909](#2909)) ([38fd001](38fd001))
* Snowflake_online_read fix ([#2988](#2988)) ([651ce34](651ce34))
* Spark source support table with pattern "db.table" ([#2606](#2606)) ([3ce5139](3ce5139)), closes [#2605](#2605)
* Switch mysql log string to use regex ([#2976](#2976)) ([5edf4b0](5edf4b0))
* Update gopy to point to fork to resolve github annotation errors. ([#2940](#2940)) ([ba2dcf1](ba2dcf1))
* Version entity serialization mechanism and fix issue with int64 vals ([#2944](#2944)) ([d0d27a3](d0d27a3))

### Features

* Add an experimental lambda-based materialization engine ([#2923](#2923)) ([6f79069](6f79069))
* Add column reordering to `write_to_offline_store` ([#2876](#2876)) ([8abc2ef](8abc2ef))
* Add custom JSON table tab w/ formatting ([#2851](#2851)) ([0159f38](0159f38))
* Add CustomSourceOptions to SavedDatasetStorage ([#2958](#2958)) ([23c09c8](23c09c8))
* Add Go option to `feast serve` command ([#2966](#2966)) ([a36a695](a36a695))
* Add interfaces for batch materialization engine ([#2901](#2901)) ([38b28ca](38b28ca))
* Add pages for individual Features to the Feast UI ([#2850](#2850)) ([9b97fca](9b97fca))
* Add snowflake online store ([#2902](#2902)) ([f758f9e](f758f9e)), closes [#2903](#2903)
* Add Snowflake online store (again) ([#2922](#2922)) ([2ef71fc](2ef71fc)), closes [#2903](#2903)
* Add to_remote_storage method to RetrievalJob ([#2916](#2916)) ([109ee9c](109ee9c))
* Support retrieval from multiple feature views with different join keys ([#2835](#2835)) ([056cfa1](056cfa1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevjumba @codecov-commenter @feast-ci-bot @achals