fix: Spark source support table with pattern "db.table" #2606

kfiring · 2022-04-25T01:34:29Z

…ps://github.com//issues/2605)

Signed-off-by: leonpeng [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2605

achals · 2022-04-25T01:42:11Z

/ok-to-test

Thanks for the PR @kfiring! Could you add a test that verifies this change?

codecov-commenter · 2022-04-25T02:05:55Z

Codecov Report

Merging #2606 (5870d8f) into master (e4507ac) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 5870d8f differs from pull request most recent head 30117ec. Consider uploading reports for the commit 30117ec to get more accurate results

@@            Coverage Diff             @@
##           master    #2606      +/-   ##
==========================================
- Coverage   77.67%   77.62%   -0.05%     
==========================================
  Files         186      186              
  Lines       16364    16365       +1     
==========================================
- Hits        12710    12703       -7     
- Misses       3654     3662       +8

Flag	Coverage Δ
integrationtests	`68.60% <0.00%> (-0.15%)`	⬇️
unittests	`58.52% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...stores/contrib/spark_offline_store/spark_source.py	`60.71% <0.00%> (-0.44%)`	⬇️
sdk/python/tests/utils/online_read_write_test.py	`93.54% <0.00%> (-6.46%)`	⬇️
.../integration/online_store/test_online_retrieval.py	`96.84% <0.00%> (-3.16%)`	⬇️
sdk/python/feast/infra/online_stores/datastore.py	`87.96% <0.00%> (-1.39%)`	⬇️
...east/infra/materialization/lambda/lambda_engine.py	`93.75% <0.00%> (+1.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4507ac...30117ec. Read the comment docs.

achals · 2022-04-26T03:54:20Z

sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py

@@ -172,7 +175,9 @@ def get_table_query_string(self) -> str:
        """Returns a string that can directly be used to reference this table in SQL"""
        if self.table:
            # Backticks make sure that spark sql knows this a table reference.
-            return f"`{self.table}`"
+            # return f"`{self.table}`"
+            table = '.'.join(map(lambda x: f'`{x}`', self.table.split('.')))


nit, map and lambda are generally avoided in favor of list comprehensions:
``

Suggested change

table = '.'.join(map(lambda x: f'`{x}`', self.table.split('.')))

table = '.'.join([f"`{x}`" for x in self.table.split('.')])

achals · 2022-04-26T03:55:23Z

Thanks for the PR @kfiring! Do you mind addressing lint/DCO?

…#2605 feast-dev#2605) Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Kevin Zhang <[email protected]>

felixwang9817

/lgtm

feast-ci-bot · 2022-07-26T18:42:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kfiring

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# [0.23.0](v0.22.0...v0.23.0) (2022-08-02) ### Bug Fixes * Add dummy alias to pull_all_from_table_or_query ([#2956](#2956)) ([5e45228](5e45228)) * Bump version of Guava to mitigate cve ([#2896](#2896)) ([51df8be](51df8be)) * Change numpy version on setup.py and upgrade it to resolve dependabot warning ([#2887](#2887)) ([80ea7a9](80ea7a9)) * Change the feature store plan method to public modifier ([#2904](#2904)) ([0ec7d1a](0ec7d1a)) * Deprecate 3.7 wheels and fix verification workflow ([#2934](#2934)) ([040c910](040c910)) * Do not allow same column to be reused in data sources ([#2965](#2965)) ([661c053](661c053)) * Fix build wheels workflow to install apache-arrow correctly ([#2932](#2932)) ([bdeb4ae](bdeb4ae)) * Fix file offline store logic for feature views without ttl ([#2971](#2971)) ([26f6b69](26f6b69)) * Fix grpc and update protobuf ([#2894](#2894)) ([86e9efd](86e9efd)) * Fix night ci syntax error and update readme ([#2935](#2935)) ([b917540](b917540)) * Fix nightly ci again ([#2939](#2939)) ([1603c9e](1603c9e)) * Fix the go build and use CgoArrowAllocator to prevent incorrect garbage collection ([#2919](#2919)) ([130746e](130746e)) * Fix typo in CONTRIBUTING.md ([#2955](#2955)) ([8534f69](8534f69)) * Fixing broken links to feast documentation on java readme and contribution ([#2892](#2892)) ([d044588](d044588)) * Fixing Spark min / max entity df event timestamps range return order ([#2735](#2735)) ([ac55ce2](ac55ce2)) * Move gcp back to 1.47.0 since grpcio-tools 1.48.0 got yanked from pypi ([#2990](#2990)) ([fc447eb](fc447eb)) * Refactor testing and sort out unit and integration tests ([#2975](#2975)) ([2680f7b](2680f7b)) * Remove hard-coded integration test setup for AWS & GCP ([#2970](#2970)) ([e4507ac](e4507ac)) * Resolve small typo in README file ([#2930](#2930)) ([16ae902](16ae902)) * Revert "feat: Add snowflake online store ([#2902](#2902))" ([#2909](#2909)) ([38fd001](38fd001)) * Snowflake_online_read fix ([#2988](#2988)) ([651ce34](651ce34)) * Spark source support table with pattern "db.table" ([#2606](#2606)) ([3ce5139](3ce5139)), closes [#2605](#2605) * Switch mysql log string to use regex ([#2976](#2976)) ([5edf4b0](5edf4b0)) * Update gopy to point to fork to resolve github annotation errors. ([#2940](#2940)) ([ba2dcf1](ba2dcf1)) * Version entity serialization mechanism and fix issue with int64 vals ([#2944](#2944)) ([d0d27a3](d0d27a3)) ### Features * Add an experimental lambda-based materialization engine ([#2923](#2923)) ([6f79069](6f79069)) * Add column reordering to `write_to_offline_store` ([#2876](#2876)) ([8abc2ef](8abc2ef)) * Add custom JSON table tab w/ formatting ([#2851](#2851)) ([0159f38](0159f38)) * Add CustomSourceOptions to SavedDatasetStorage ([#2958](#2958)) ([23c09c8](23c09c8)) * Add Go option to `feast serve` command ([#2966](#2966)) ([a36a695](a36a695)) * Add interfaces for batch materialization engine ([#2901](#2901)) ([38b28ca](38b28ca)) * Add pages for individual Features to the Feast UI ([#2850](#2850)) ([9b97fca](9b97fca)) * Add snowflake online store ([#2902](#2902)) ([f758f9e](f758f9e)), closes [#2903](#2903) * Add Snowflake online store (again) ([#2922](#2922)) ([2ef71fc](2ef71fc)), closes [#2903](#2903) * Add to_remote_storage method to RetrievalJob ([#2916](#2916)) ([109ee9c](109ee9c)) * Support retrieval from multiple feature views with different join keys ([#2835](#2835)) ([056cfa1](056cfa1))

feast-ci-bot added the size/S label Apr 25, 2022

feast-ci-bot added the ok-to-test label Apr 25, 2022

adchia changed the title ~~1. fix: spark source support table with pattern "db.table" (#2605 htt…~~ fix: spark source support table with pattern "db.table" Apr 25, 2022

achals reviewed Apr 26, 2022

View reviewed changes

kevjumba changed the title ~~fix: spark source support table with pattern "db.table"~~ fix: Spark source support table with pattern "db.table" Jul 26, 2022

kevjumba force-pushed the master branch from 4ba4f72 to 986a93f Compare July 26, 2022 18:12

feast-ci-bot added size/XS and removed size/S labels Jul 26, 2022

kevjumba force-pushed the master branch from 986a93f to 5870d8f Compare July 26, 2022 18:13

leonpeng and others added 2 commits July 26, 2022 11:17

1. fix: spark source support table with pattern "db.table" (feast-dev…

70c7c24

…#2605 feast-dev#2605) Signed-off-by: Kevin Zhang <[email protected]>

Fix lint

30117ec

Signed-off-by: Kevin Zhang <[email protected]>

kevjumba force-pushed the master branch from 5870d8f to 30117ec Compare July 26, 2022 18:17

felixwang9817 approved these changes Jul 26, 2022

View reviewed changes

feast-ci-bot assigned felixwang9817 Jul 26, 2022

feast-ci-bot added the lgtm label Jul 26, 2022

feast-ci-bot added the approved label Jul 26, 2022

feast-ci-bot merged commit 3ce5139 into feast-dev:master Jul 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Spark source support table with pattern "db.table" #2606

fix: Spark source support table with pattern "db.table" #2606

kfiring commented Apr 25, 2022 •

edited by kevjumba

Loading

achals commented Apr 25, 2022

codecov-commenter commented Apr 25, 2022 •

edited

Loading

achals Apr 26, 2022

achals commented Apr 26, 2022

felixwang9817 left a comment

feast-ci-bot commented Jul 26, 2022

	table = '.'.join(map(lambda x: f'`{x}`', self.table.split('.')))
	table = '.'.join([f"`{x}`" for x in self.table.split('.')])

fix: Spark source support table with pattern "db.table" #2606

fix: Spark source support table with pattern "db.table" #2606

Conversation

kfiring commented Apr 25, 2022 • edited by kevjumba Loading

achals commented Apr 25, 2022

codecov-commenter commented Apr 25, 2022 • edited Loading

Codecov Report

achals Apr 26, 2022

Choose a reason for hiding this comment

achals commented Apr 26, 2022

felixwang9817 left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Jul 26, 2022

kfiring commented Apr 25, 2022 •

edited by kevjumba

Loading

codecov-commenter commented Apr 25, 2022 •

edited

Loading