Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Create SparkSource inside try catch #2408

Closed
wants to merge 1 commit into from
Closed

fix: Create SparkSource inside try catch #2408

wants to merge 1 commit into from

Conversation

aurobindoc
Copy link
Contributor

Signed-off-by: aurobindoc [email protected]

Which issue(s) this PR fixes:
Fixes #2407

@aurobindoc aurobindoc requested a review from a team as a code owner March 15, 2022 09:07
@aurobindoc aurobindoc requested review from adchia and removed request for a team March 15, 2022 09:07
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aurobindoc
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aurobindoc aurobindoc changed the title Create SparkSource inside try catch fix: create SparkSource inside try catch Mar 15, 2022
@aurobindoc aurobindoc changed the title fix: create SparkSource inside try catch fix: Create SparkSource inside try catch Mar 15, 2022
@woop
Copy link
Member

woop commented Mar 15, 2022

@aurobindoc Thanks for the PR. I think we should first address #2409 before moving forward here.

1 similar comment
@woop
Copy link
Member

woop commented Mar 15, 2022

@aurobindoc Thanks for the PR. I think we should first address #2409 before moving forward here.

@adchia
Copy link
Collaborator

adchia commented Mar 17, 2022

See this for I think the better fix! #2415

Verified this also fixes the Spark issue

@adchia adchia closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adchia adchia Awaiting requested review from adchia adchia was automatically assigned from feast-dev/maintainers

Assignees

@woop woop

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feast apply fails for Spark Offline Store once the registry has been created
4 participants
@aurobindoc @feast-ci-bot @woop @adchia