Data source conversion from protobuf doesn't use type information

[woop]

For some reason we are using field names

feast/sdk/python/feast/data_source.py

Line 217 in b35e1e8

if data_source.request_data_options and data_source.request_data_options.schema:

to infer data source types. We should be using the actual data source types in the protos.

Also,

feast/sdk/python/feast/data_source.py

Line 213 in b35e1e8

if data_source.data_source_class_type:

doesnt exist

[felixwang9817]

@woop what do you mean by doesn't exist? I see data_source_class_type in DataSource.proto:

// This is an internal field that is represents the python class for the data source object a proto object represents.
// This should be set by feast, and not by users.
string data_source_class_type = 17;

and I also see it being set correctly in the code:

batch_source_proto = self.batch_source.to_proto()
batch_source_proto.data_source_class_type = f"{self.batch_source.__class__.__module__}.{self.batch_source.__class__.__name__}"

[adchia]

Yep. I think there is some bug that might have been introduced when we started storing data sources separately since the feature view class adds that, but i don't think we add this class_type with applying data sources to the registry.