Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute property-level diffs for repo objects #2156

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

achals
Copy link
Member

@achals achals commented Dec 16, 2021

Screen Shot 2021-12-16 at 3 52 14 PM

Signed-off-by: Achal Shah

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

`feast plan` and `feast apply` output produces property-level diffs for objects changed in-place.

@achals
Copy link
Member Author

achals commented Dec 16, 2021

cc @judahrand since you asked about this erlier

@codecov-commenter
Copy link

Codecov Report

Merging #2156 (0e4eac8) into master (ce243a4) will decrease coverage by 0.21%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
- Coverage   84.64%   84.42%   -0.22%     
==========================================
  Files         101      101              
  Lines        8037     8098      +61     
==========================================
+ Hits         6803     6837      +34     
- Misses       1234     1261      +27     
Flag Coverage Δ
integrationtests 74.36% <82.35%> (-0.48%) ⬇️
unittests 58.80% <82.35%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 48.37% <0.00%> (-0.69%) ⬇️
sdk/python/feast/diff/FcoDiff.py 90.47% <100.00%> (+2.47%) ⬆️
sdk/python/feast/registry.py 87.24% <100.00%> (+0.04%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 80.11% <0.00%> (-11.23%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 84.78% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce243a4...0e4eac8. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 1cfc25c into feast-dev:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants