Fix inference

Signed-off-by: Achal Shah <[email protected]>
feast-dev · Dec 16, 2021 · 0e4eac8 · 0e4eac8
1 parent c4f9c52
commit 0e4eac8
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/sdk/python/feast/diff/FcoDiff.py b/sdk/python/feast/diff/FcoDiff.py
@@ -83,15 +83,13 @@ def tag_proto_objects_for_keep_delete_add(
 def diff_between(current: U, new: U, object_type: str) -> FcoDiff:
     assert current.DESCRIPTOR.full_name == new.DESCRIPTOR.full_name
     property_diffs = []
-    transition: TransitionType
-    if current.spec == new.spec:
-        transition = TransitionType.UNCHANGED
-    else:
-        transition = TransitionType.UPDATE
+    transition: TransitionType = TransitionType.UNCHANGED
+    if current.spec != new.spec:
         for _field in current.spec.DESCRIPTOR.fields:
             if _field.name in FIELDS_TO_IGNORE:
                 continue
             if getattr(current.spec, _field.name) != getattr(new.spec, _field.name):
+                transition = TransitionType.UPDATE
                 property_diffs.append(
                     PropertyDiff(
                         _field.name,