Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init to Provider contract #1796

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Add init to Provider contract #1796

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf91ee0
Add init to provider
woop Aug 23, 2021
a1eeba1
Update call site to not have repo_path
woop Aug 24, 2021
729759e
Add init to FooProvider
woop Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sdk/python/feast/infra/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@


class Provider(abc.ABC):
@abc.abstractmethod
def __init__(self, config: RepoConfig):
woop marked this conversation as resolved.
Show resolved Hide resolved
...

@abc.abstractmethod
def update_infra(
self,
Expand Down Expand Up @@ -161,7 +165,7 @@ def get_provider(config: RepoConfig, repo_path: Path) -> Provider:

cls = importer.get_class_from_type(module_name, class_name, "Provider")

return cls(config, repo_path)
return cls(config)


def _get_requested_feature_views_to_features_dict(
Expand Down