Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init to Provider contract #1796

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Add init to Provider contract #1796

merged 3 commits into from
Aug 30, 2021

Conversation

woop
Copy link
Member

@woop woop commented Aug 22, 2021

What this PR does / why we need it:

This PR adds an abstract __init__ as part of the base class for Providers. Currently no such method exists which has led to custom providers and built in providers having different initialization contracts.

return GcpProvider(config)

vs
return cls(config, repo_path)

Does this PR introduce a user-facing change?:

All custom providers must now provide an initialization method and won't receive a repo_path argument

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021

Codecov Report

Merging #1796 (729759e) into master (a48bcd0) will decrease coverage by 20.94%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1796       +/-   ##
===========================================
- Coverage   84.85%   63.90%   -20.95%     
===========================================
  Files          92       89        -3     
  Lines        6826     6719      -107     
===========================================
- Hits         5792     4294     -1498     
- Misses       1034     2425     +1391     
Flag Coverage Δ
integrationtests ?
unittests 63.90% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/provider.py 84.07% <50.00%> (-5.03%) ⬇️
.../integration/online_store/test_universal_online.py 16.32% <0.00%> (-83.68%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 20.25% <0.00%> (-79.75%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...hon/tests/integration/registration/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
...n/tests/integration/registration/test_cli_redis.py 32.55% <0.00%> (-67.45%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-64.29%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 31.03% <0.00%> (-62.07%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48bcd0...729759e. Read the comment docs.

@woop woop added the compat/breaking Breaking user-facing change label Aug 23, 2021
Signed-off-by: Willem Pienaar <[email protected]>
@woop woop force-pushed the fix-provider-init branch from 0f97de6 to bf91ee0 Compare August 23, 2021 20:30
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Willem Pienaar <[email protected]>
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@achals achals added the lgtm label Aug 27, 2021
@woop woop merged commit 7aad012 into feast-dev:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants