-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add init to Provider contract #1796
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1796 +/- ##
===========================================
- Coverage 84.85% 63.90% -20.95%
===========================================
Files 92 89 -3
Lines 6826 6719 -107
===========================================
- Hits 5792 4294 -1498
- Misses 1034 2425 +1391
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Willem Pienaar <[email protected]>
0f97de6
to
bf91ee0
Compare
Signed-off-by: Willem Pienaar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Willem Pienaar <[email protected]>
New changes are detected. LGTM label has been removed. |
What this PR does / why we need it:
This PR adds an abstract
__init__
as part of the base class for Providers. Currently no such method exists which has led to custom providers and built in providers having different initialization contracts.feast/sdk/python/feast/infra/provider.py
Line 146 in 745a1b4
vs
feast/sdk/python/feast/infra/provider.py
Line 164 in 745a1b4
Does this PR introduce a user-facing change?: