Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default cli no option help message #1550

Merged
merged 1 commit into from
May 19, 2021
Merged

Update default cli no option help message #1550

merged 1 commit into from
May 19, 2021

Conversation

tedhtchang
Copy link
Contributor

@tedhtchang tedhtchang commented May 8, 2021 •
edited
Loading

Signed-off-by: ted chang [email protected]

Fixes #1531

Does this PR introduce a user-facing change?:

NONE

@tedhtchang tedhtchang requested review from jklegar, tsotnet, woop and a team as code owners May 8, 2021 00:05
@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented May 13, 2021 •
edited
Loading

/lgtm @tedhtchang

I think you just need to rebase so that we can get this one merged!

Thanks a lot!

@tedhtchang
Copy link
Contributor Author

@woop Done and thanks!

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedhtchang, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop merged commit f2de613 into feast-dev:master May 19, 2021
woop pushed a commit that referenced this pull request May 19, 2021
@tedhtchang @woop
Update default cli no option help message (#1550)
dd2c33f 
Signed-off-by: ted chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop approved these changes

@jklegar jklegar Awaiting requested review from jklegar

@tsotnet tsotnet Awaiting requested review from tsotnet

Assignees
No one assigned
Labels
approved kind/housekeeping ok-to-test release-note-none size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feast cli minor bug
3 participants
@tedhtchang @feast-ci-bot @woop