Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feast cli minor bug #1531

Closed
dmatrix opened this issue May 5, 2021 · 4 comments · Fixed by #1550
Closed

feast cli minor bug #1531

dmatrix opened this issue May 5, 2021 · 4 comments · Fixed by #1550

Comments

@dmatrix
Copy link
Contributor

dmatrix commented May 5, 2021

Expected Behavior

feast teardown --help should list the options to this subcommand like

(feast) ➜ examples git:(br_jsd_mlflow_feast_example) ✗ feast init --help
Usage: feast init [OPTIONS] [PROJECT_DIRECTORY]

Create a new Feast repository

Options:
-m, --minimal Create an empty project repository
-t, --template [local|gcp] Specify a template for the created project
--help Show this message and exit.

Current Behavior

(base) ➜ delta-lake git:(master) ✗ feast teardown --help
Usage: feast teardown [OPTIONS]

Tear down deployed feature store infrastructure

Options:
--help Show this message and exit.

I reckon this is a generic message if the subcommand has not options. For example, feast apply --help exhibits similar
behavior.

Steps to reproduce

feast teardown --help

Specifications

  • Version: 0.10.3
  • Platform: MacOS Mojave
  • Subsystem:
@woop
Copy link
Member

woop commented May 5, 2021

Thanks @dmatrix. Definitely a few rough edges around the new CLI. Let's keep this issue open until resolved!

@tedhtchang
Copy link
Contributor

@dmatrix I'd like to fix this. What exactly should the feast teardown --help and feast apply --help print ?

@dmatrix
Copy link
Contributor Author

dmatrix commented May 5, 2021

@tedhtchang Generally speaking, most usage messages would print out options if available. For example, the
feast init --help will print out:

(base) ➜ delta-lake git:(master) ✗ feast init --help
Usage: feast init [OPTIONS] [PROJECT_DIRECTORY]

Create a new Feast repository

Options:
-m, --minimal Create an empty project repository
-t, --template [local|gcp] Specify a template for the created project
--help Show this message and exit.

If no options exist for a subcommand, then it's not unreasonable to indicate none exists, IMHO. For example, one can
envision something such as:

Usage: feast teardown [OPTIONS]

Tear down deployed feature store infrastructure

Options:(No current command options)
--help Show this message and exit.

The best place to start would be here.

cc: @woop can recommend or opine on what should the message be or what should it indicate.

@woop
Copy link
Member

woop commented May 6, 2021

Currently we don't have options for this command (teardown and apply), so following @dmatrix's second recommendation may make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants