Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: halt on connect #3514

Merged
merged 6 commits into from
Feb 13, 2023
Merged

debug: halt on connect #3514

merged 6 commits into from
Feb 13, 2023

Commits on Feb 12, 2023

  1. Configuration menu
    Copy the full SHA
    edc2182 View commit details
    Browse the repository at this point in the history
  2. debug: set default value for current goroutine indicator

    Sometimes execution will be halted at a time when there is no current
    goroutine (e.g. the process is sleeping). Default the current goroutine
    indicator so that trying to prepend the current goroutine to the list
    does not cause an error.
    bhcleek committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    44dfeb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. debug: halt on connect

    Always halt on connect so that :GoDebugConnect will halt the
    application and set up breakpoints even when delve was started with
    --continue.
    
    It is safe to halt multiple times, so it won't matter what state the
    debugger is in when halt is called.
    bhcleek committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    bb3a212 View commit details
    Browse the repository at this point in the history
  2. debug: change function names for readability

    Change function names for readability so that it is easier to reason
    about what the code is doing.
    * start_cb() -> create_layout()
    * stack_cb() -> update_windows()
    bhcleek committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    705a8ec View commit details
    Browse the repository at this point in the history
  3. debug: s:list_breakpoints -> s:list_breakpointsigns

    Rename s:list_breakpoints to s:list_breakpointsigns to disambiguate
    whether the breakpoints as understood by the debugger, dlv, or or the
    signs placed in the editor are returned.
    bhcleek committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    9766f34 View commit details
    Browse the repository at this point in the history
  4. debug: add breakpoint synchronization

    Synchronize breakpoints whenever connecting to the debugger in case it
    was started in multiclient mode and already has breakpoints set.
    bhcleek committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    eaa3012 View commit details
    Browse the repository at this point in the history