debug: halt on connect #3514
Merged
debug: halt on connect #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes execution will be halted at a time when there is no current goroutine (e.g. the process is sleeping). Default the current goroutine indicator so that trying to prepend the current goroutine to the list does not cause an error.
bhcleek
force-pushed
the
debug/connect/halt
branch
from
0c93743
to
126f7a1
Compare
Always halt on connect so that :GoDebugConnect will halt the application and set up breakpoints even when delve was started with --continue. It is safe to halt multiple times, so it won't matter what state the debugger is in when halt is called.
Change function names for readability so that it is easier to reason about what the code is doing. * start_cb() -> create_layout() * stack_cb() -> update_windows()
Rename s:list_breakpoints to s:list_breakpointsigns to disambiguate whether the breakpoints as understood by the debugger, dlv, or or the signs placed in the editor are returned.
Synchronize breakpoints whenever connecting to the debugger in case it was started in multiclient mode and already has breakpoints set.
bhcleek
force-pushed
the
debug/connect/halt
branch
from
126f7a1
to
eaa3012
Compare
bhcleek
added a commit
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug: use s:isReady() consistently
debug: set default value for current goroutine indicator
Sometimes execution will be halted at a time when there is no current
goroutine (e.g. the process is sleeping). Default the current goroutine
indicator so that trying to prepend the current goroutine to the list
does not cause an error.
debug: halt on connect
Always halt on connect so that :GoDebugConnect will halt the
application and set up breakpoints even when delve was started with
--continue.
It is safe to halt multiple times, so it won't matter what state the
debugger is in when halt is called.
debug: change function names for readability
Change function names for readability so that it is easier to reason
about what the code is doing.
debug: s:list_breakpoints -> s:list_breakpointsigns
Rename s:list_breakpoints to s:list_breakpointsigns to disambiguate
whether the breakpoints as understood by the debugger, dlv, or or the
signs placed in the editor are returned.
debug: add breakpoint synchronization
Synchronize breakpoints whenever connecting to the debugger in case it
was started in multiclient mode and already has breakpoints set.
Fixes #3508