Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for fastify v5 #107

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Updates for fastify v5 #107

merged 2 commits into from
Nov 1, 2023

Conversation

nrayburn-tech
Copy link
Contributor

@nrayburn-tech nrayburn-tech commented Nov 1, 2023

Drop node <= 16 from workflows
Add node 21 to benchmark-pr
Add node 21 to ci-package-manager for yarn

Fixes #106, #92.

Checklist

Add node 21 to benchmark-pr
Add node 21 to ci-package-manager for yarn
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jsumners jsumners merged commit 29329a1 into fastify:main Nov 1, 2023
1 check passed
@jsumners
Copy link
Member

jsumners commented Nov 1, 2023

The v4 tag has been created.

@mcollina
Copy link
Member

mcollina commented Nov 1, 2023

Let's hope this does not get auto-updated across the entire fleet, otherwise it would be a nightmare to revert.

@jsumners
Copy link
Member

jsumners commented Nov 1, 2023

It shouldn't. But what in the actual eff Dependabot? fastify/releasify#283

@Fdawgs I believe you have setup the majority of the Dependabot stuff. Do you know why it would automatically update the major versions of workflows?

@Fdawgs
Copy link
Member

Fdawgs commented Nov 1, 2023

@mcollina
Copy link
Member

mcollina commented Nov 1, 2023

@Fdawgs would this land automatically then?

@Fdawgs
Copy link
Member

Fdawgs commented Nov 1, 2023

@Fdawgs would this land automatically then?

Unfortunately, yes. Can see it making its way through all the reps now. 😵‍💫

@jsumners
Copy link
Member

jsumners commented Nov 1, 2023

We really should not be updating at least our own workflows's major version automatically. The whole point of the versioning, particularly in this repo, is to indicate breaking changes in the workflow.

@jsumners
Copy link
Member

jsumners commented Nov 1, 2023

How do we stop the linked tool from updating all of our repos automatically for this?

@jsumners
Copy link
Member

jsumners commented Nov 1, 2023

@nrayburn-tech I have removed the v4 tag for right now. To continue your work, use the git SHA. I will restore the v4 tag once we have fixed the above discussed problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create a v4 set
4 participants