-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for fastify v5 #107
Conversation
Add node 21 to benchmark-pr Add node 21 to ci-package-manager for yarn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The v4 tag has been created. |
Let's hope this does not get auto-updated across the entire fleet, otherwise it would be a nightmare to revert. |
It shouldn't. But what in the actual eff Dependabot? fastify/releasify#283 @Fdawgs I believe you have setup the majority of the Dependabot stuff. Do you know why it would automatically update the major versions of workflows? |
https://github.com/fastify/github-action-merge-dependabot working as intended. |
@Fdawgs would this land automatically then? |
Unfortunately, yes. Can see it making its way through all the reps now. 😵💫 |
We really should not be updating at least our own workflows's major version automatically. The whole point of the versioning, particularly in this repo, is to indicate breaking changes in the workflow. |
How do we stop the linked tool from updating all of our repos automatically for this? |
@nrayburn-tech I have removed the v4 tag for right now. To continue your work, use the git SHA. I will restore the v4 tag once we have fixed the above discussed problem. |
Drop node <= 16 from workflows
Add node 21 to benchmark-pr
Add node 21 to ci-package-manager for yarn
Fixes #106, #92.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct