Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a v4 set #106

Closed
jsumners opened this issue Oct 31, 2023 · 2 comments · Fixed by #107
Closed

Create a v4 set #106

jsumners opened this issue Oct 31, 2023 · 2 comments · Fixed by #107

Comments

@jsumners
Copy link
Member

A new v4 tag should be create that points to a set of workflows that drop Node.js <=16. Any changes to v3 should happen on the https://github.com/fastify/workflows/tree/v3.y.z branch.

@nrayburn-tech
Copy link
Contributor

If outside contributors are welcome for this, I can make a PR for it.

Should the PR target main, or should a v4 branch be created first?
Is it possible to test the changes before putting up a PR? (Maybe in combination with the PR I'm going to make for fastify/fast-content-type-parse#20?)

@jsumners
Copy link
Member Author

jsumners commented Nov 1, 2023

@nrayburn-tech you are welcome to take this on. For this, you can target the main branch.

The only real way to test these things is to publish them and use them in a project. So once we have a new v4 tag on main, a repo can reference it in a new PR and that PR's CI will use it. We don't need to worry about churn on the v4 tag if issues pop up. Nothing should be using it except for the PR(s) referencing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants