Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually emit drain when backpressure kicks in #329

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Actually emit drain when backpressure kicks in #329

merged 1 commit into from
Jan 8, 2025

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jan 8, 2025

Checklist

@mcollina mcollina added the bug label Jan 8, 2025
@mcollina mcollina requested review from jsumners, Eomm and Fdawgs January 8, 2025 17:04
Uzlopak
Uzlopak approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I understand this.
RSLGTM

@mcollina mcollina merged commit bae8423 into master Jan 8, 2025
14 of 15 checks passed
@mcollina mcollina deleted the actually-emit-drain branch January 8, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@jsumners jsumners Awaiting requested review from jsumners

@Eomm Eomm Awaiting requested review from Eomm

@Fdawgs Fdawgs Awaiting requested review from Fdawgs

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @Uzlopak