Actually emit drain when backpressure kicks in (#329)

Signed-off-by: Matteo Collina <[email protected]>
fastify · Jan 8, 2025 · bae8423 · bae8423
1 parent 2513cdf
commit bae8423
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/response.js b/lib/response.js
@@ -10,7 +10,8 @@ function Response (req, onEnd, reject) {
   http.ServerResponse.call(this, req)
 
   if (req._lightMyRequest?.payloadAsStream) {
-    this._lightMyRequest = { headers: null, trailers: {}, stream: new Readable({ read () {} }) }
+    const read = this.emit.bind(this, 'drain')
+    this._lightMyRequest = { headers: null, trailers: {}, stream: new Readable({ read }) }
     const signal = req._lightMyRequest.signal
 
     if (signal) {

diff --git a/test/stream.test.js b/test/stream.test.js
@@ -109,7 +109,9 @@ test('stream mode - backpressure', (t, done) => {
     const buf = Buffer.alloc(1024 * 1024).fill('b')
     t.assert.strictEqual(res.write(buf), false)
     expected = 'a' + buf.toString()
-    res.end()
+    res.on('drain', () => {
+      res.end()
+    })
   }
 
   inject(dispatch, { method: 'GET', url: '/', payloadAsStream: true }, (err, res) => {