feat: fastify 5 with separated type-providers #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah so this PR might need to be combined with, or merged after, #137 (for tests and dependencies) Feel free to take over that as well or I can look into it tonight |
Closed
4 tasks
|
Please pull from the next branch |
|
Why is this PR closed? These type definition changes are approved and will break this project. |
|
The target branch got merged and deleted. So GitHub closed it automatically. |
|
Alright, I think the tests should run now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
The tests will not work since this fastify 5 change has not been committed yet.
This is a patch to work correctly with fastify/fastify#5427