Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Fastify v5 #137

Merged
merged 8 commits into from
Jun 15, 2024
Merged

Update for Fastify v5 #137

merged 8 commits into from
Jun 15, 2024

Conversation

gurgunday
Copy link
Member

No description provided.

@gurgunday

This comment was marked as outdated.

@gurgunday gurgunday requested review from Fdawgs and a team June 12, 2024 20:45
.taprc Outdated
@@ -0,0 +1,7 @@
# vim: set filetype=yaml :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to the vim line, but please name the file .taprc.yaml and add "tap": "./.taprc.yaml" to package.json.

tapjs/tapjs#1026

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, but can I just remove it for this PR?

I think I added it because of a linting problem, or it could be the tap cli (more likely)

This seems like it could be done much faster at the org scale with a script

Cc @Fdawgs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not something we need to go off and blow up all of our inboxes with. If you're doing some work in a repo and see it lacking, go ahead and update it. That's the intention here: you're already making changes regarding this file and how it is recognized by the tool.

Let me be clear: please do not flood my inbox with changes across all of our repos for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me be clear: please do not flood my inbox with changes across all of our repos for this.

haha sure, yeah I get how annoying those are!

@gurgunday gurgunday merged commit 1f0beb5 into fastify:next Jun 15, 2024
14 checks passed
@gurgunday gurgunday deleted the v5 branch June 15, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants