-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Fastify v5 #137
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
.taprc
Outdated
@@ -0,0 +1,7 @@ | |||
# vim: set filetype=yaml : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to the vim line, but please name the file .taprc.yaml
and add "tap": "./.taprc.yaml"
to package.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, but can I just remove it for this PR?
I think I added it because of a linting problem, or it could be the tap cli (more likely)
This seems like it could be done much faster at the org
scale with a script
Cc @Fdawgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not something we need to go off and blow up all of our inboxes with. If you're doing some work in a repo and see it lacking, go ahead and update it. That's the intention here: you're already making changes regarding this file and how it is recognized by the tool.
Let me be clear: please do not flood my inbox with changes across all of our repos for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me be clear: please do not flood my inbox with changes across all of our repos for this.
haha sure, yeah I get how annoying those are!
No description provided.