Remove the deprecated addToBody option and return files as buffers when attachFieldsToBody is set to keyValues #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es'` (#468) * return buffer directly * add test * move tap path to taprc * update README.md * typo * refactor keyValues handler * use already set variable * use for...of * ditch for...of for Arrays * use keys rather than entries
* remove deprecated method * remove unused package * revert modification * remove addToBody documentation * remove request.multipart type * remove legacy comment
Merge main into next
|
Does it close this issue too #464? |
|
That one is more about the actual rewrite we wanted to do. Maybe we can remove “restructure” from its title The following however can be closed as we are removing the buggy API while having an alternative that works: #435 |
|
Anyone wants to add a breaking change? Last call! |
Fdawgs
requested changes
Sep 27, 2023
|
Probably also needs a more descriptive PR title rather than v8? 😋 |
Co-authored-by: Frazer Smith <[email protected]>
Co-authored-by: Frazer Smith <[email protected]>
gurgunday
changed the title
gurgunday
changed the title
Fdawgs
approved these changes
Sep 28, 2023
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been multiple requests to make a major release as we fixed an annoying issue, but so far we've held it back to combine these changes with a rewrite of the plugin
I think as @mcollina said, bumping major is cheap and we can release v9 in the future when the rewrite is complete
Closes #447 and closes #456, closes #289, closes #202 closes #435
Checklist
npm run testandnpm run benchmarkand the Code of conduct