Remove legacy addToBody and callback API #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would be attachFieldsToBody: true or even better attachFieldsToBody: “keyValues” https://github.com/fastify/fastify-multipart#parse-all-fields-and-assign-them-to-the-body addToBody is an undocumented option that uses a deprecated method (ref: #289) |
mcollina
approved these changes
Jul 27, 2023
4 tasks
2 tasks
|
Can we merge this?
|
gurgunday
changed the title
|
CC @climba03003 |
mcollina
pushed a commit
that referenced
this pull request
Sep 28, 2023
…en attachFieldsToBody is set to keyValues (#481) * Return buffers directly when `attachFieldsToBody` is set to `'keyValues'` (#468) * return buffer directly * add test * move tap path to taprc * update README.md * typo * refactor keyValues handler * use already set variable * use for...of * ditch for...of for Arrays * use keys rather than entries * Remove legacy addToBody and callback API (#465) * remove deprecated method * remove unused package * revert modification * remove addToBody documentation * remove request.multipart type * remove legacy comment * Use for loop for arrays and fix schema option for `keyValues` (#474) * only add schema when attachfieldstobody is true * fs/promises * use `for` for arrays * conditionally call Object.values * fix lint * Update test/multipart-attach-body.test.js Co-authored-by: Frazer Smith <[email protected]> * Update README.md Co-authored-by: Frazer Smith <[email protected]> --------- Co-authored-by: Uzlopak <[email protected]> Co-authored-by: Frazer Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw #464 and got excited about this plugin again 🤠
We can start by removing the
addToBodyoption that has been deprecated (or at least undocumented) for nearly 2 years nowAFAICT, this closes #289, closes #202 (line coverage gets to 100%), and maybe even #435 (by removing the related part of the code)
Checklist
npm run testandnpm run benchmarkand the Code of conduct