Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 100% coverage #29

Merged
merged 1 commit into from
Dec 3, 2020
Merged

test: 100% coverage #29

merged 1 commit into from
Dec 3, 2020

Conversation

simoneb
Copy link
Contributor

@simoneb simoneb commented Dec 2, 2020 •
edited
Loading

Fixes #18

  • remove some defaults checks which are unnecessary
  • remove cache as it's never used
  • add 100 flag to taprc

Checklist

Eomm
Eomm reviewed Dec 2, 2020
View reviewed changes
SerializerManager.js
}

findSerializer (types) {
const cacheValue = this.cache[types]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how this is never used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explained in a comment to the linked issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thks, I re-read now

The cache is broken
#30

@mcollina
Copy link
Member

mcollina commented Dec 2, 2020

I would prefer the cache to be fixed

@simoneb
Copy link
Contributor Author

simoneb commented Dec 2, 2020

I would prefer the cache to be fixed

I can agree and it's tracked in #30, but it has nothing to do with this PR. The cache was already broken, this PR simply shows that it was.

mcollina
mcollina approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simoneb simoneb mentioned this pull request Dec 2, 2020
Merged
4 tasks
@mcollina mcollina merged commit c1df293 into fastify:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

100% code coverage
3 participants
@simoneb @mcollina @Eomm