Cache

[simoneb]

Fixes #30

Not an extremely elegant solution, but minimal code changes to make the cache work.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[mcollina]

Can you please add a test?

[simoneb]

Can you please add a test?

I considered that, but then I figured that if we have 100 on tap it means that the cache is already tested.

If we want to test it explicitly instead, we may need to extract it so that it can be provided as a plugin option (can't think of any other way to test it directly). It's probably easy to do but it modifies the plugin interface so it also has to be documented.

wdyt?

[mcollina]

lgtm

[mcollina]

this is ok, no worries

[climba03003]

here is my concern about your cache implementation.
#30 (comment)

You can test the caches by specify two different route level serializer with same type but different behavior. and compare the expected result. if the serialized results are the same the test should fail because it break the route level serializer usage.

Another test that needed is, specify a route level serializer for an accepted type that global serializer do not have. then trigger the route once and trigger another route that do not have the route level serializer. if it do not throw an error, it means the caches is polluted by the route level config.

[Eomm]

I would agree with @climba03003 , but... the custom configuration per route is documented but not implemented!

This snippet doesn't work:

const fastify = require('fastify')()

fastify.register(require('./index'), {
  default: 'application/json'
})

fastify.get('/', {
  config: {
    serializer: {
      serializers: [{
        regex: /^application\/yaml$/,
        serializer: body => 'yaml-custom-no-global-one'
      }]
    }
  }
},
(req, reply) => { reply.send({ foo: 'bar' }) })

fastify.inject({
  url: '/',
  headers: {
    Accept: 'application/yaml'
  }
}, (_, res) => {
  console.log(res.statusCode)
  console.log(res.payload) // expected yaml-custom-no-global-one it is a json: {"foo":"bar"}
})

While, registering the plugin like this works as expected:

fastify.register(require('./index'), {
  serializers: [
    {
      regex: /^application\/yaml$/,
      serializer: body => 'yaml-global'
    }
  ],
  default: 'application/json'
})

The tests confirm this:

fastify-accepts-serializer/test/test.js

Line 255 in c1df293

test('serializer per route', t => {

Opening a new issue about it

[simoneb]

@Eomm @climba03003 does this PR need further work?

[Eomm]

LGTM