-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OTLP/Traces output support #613
Conversation
Hi, This is a terrific idea and PR!!! Thanks a lot. I'm in holidays til next Monday, I'll review asap. |
Using below
|
Huh 1st thought it was kinda crazy to fold these as Traces, much appreciate your feedback! |
I did a first review, still have to read the whole logic and understand how it works |
Signed-off-by: JuanJo Ciarlante <[email protected]>
Thanks, doing |
…ntArgs` Signed-off-by: JuanJo Ciarlante <[email protected]>
…as documented) Signed-off-by: JuanJo Ciarlante <[email protected]>
Update: stack deployed via |
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
LGTM label has been added. Git tree hash: 309a97a9393afed7a5257a7b4e90675864bbb40b
|
woOOOT ... thanks @Issif especially for the advice and patience towards making this PR a reality 😃! |
it remains 2 lint errors and a build issue, can you check them please |
Signed-off-by: JuanJo Ciarlante <[email protected]>
on them |
Signed-off-by: JuanJo Ciarlante <[email protected]>
/lgtm |
LGTM label has been added. Git tree hash: f96ce03f839d3a6c1fb80d205b4bf445fa9e24ba
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, jjo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Implements OTLP/Traces (OpenTelemetry) output.
Folding Falco events into traces allows them to be represented as "hierarchical" views.
Using a TraceID taken from
container.id
(or any arbitrary output fields configured by the user), all Falco events will be "rooted" under the container (or fieldset) where it occurred, enabling a tree~ish view of these.Which issue(s) this PR fixes:
Special notes for your reviewer:
Will provide some screenshots of these hierarchical views, as shown by an OTLP Traces backend like Jaeger or Grafana Tempo.