Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jjo/otlp wip #612

Closed
wants to merge 43 commits into from
Closed

Jjo/otlp wip #612

wants to merge 43 commits into from

Conversation

jjo
Copy link
Contributor

@jjo jjo commented Aug 31, 2023

What type of PR is this?
/kind feature

Any specific area of the project related to this PR?
/area outputs

What this PR does / why we need it:
Implements OTLP/Traces (OpenTelemetry) output.

Folding Falco events into traces allows them to be represented as "hierarchical" views.
Using a TraceID taken from container.id (or Kubernetes labels down to k8s.pod.name if present), all Falco events will be "rooted" under the container where it occurred, enabling a tree~ish view of these.

Which issue(s) this PR fixes:

Special notes for your reviewer:
Will provide some screenshots of these hierarchical views, as shown by an OTLP Traces backend like Jaeger or Grafana Tempo.

jjo and others added 30 commits August 31, 2023 11:39
Signed-off-by: JuanJo Ciarlante <[email protected]>
…add gcompat to alpine image to be able to use locally built binary

Signed-off-by: JuanJo Ciarlante <[email protected]>
…an, it also greatly improves TempoQL UX

Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
jjo added 13 commits August 31, 2023 11:39
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
@poiana
Copy link

poiana commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jjo
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Aug 31, 2023

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@poiana
Copy link

poiana commented Aug 31, 2023

Welcome @jjo! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@jjo jjo closed this Aug 31, 2023
@jjo
Copy link
Contributor Author

jjo commented Aug 31, 2023

Welcome @jjo! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

Thanks!, mis-submitted this from my WIP branch, re- submitted as #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants