Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typing): finalize annotations #2338

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Sep 23, 2024

Finish typing falcon.
This also fixes #2207

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0b9d26c) to head (c86c544).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2338   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7507      7547   +40     
  Branches      1238      1238           
=========================================
+ Hits          7507      7547   +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 changed the title Finish typing feat(typing): finalize annotations Sep 23, 2024
@CaselIT CaselIT requested a review from vytas7 September 23, 2024 17:21
vytas7
vytas7 previously approved these changes Sep 24, 2024
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most of it, I'll add a note to the cleanup issue to revise Headers though. 👍

@vytas7 vytas7 merged commit 08ee3c0 into falconry:master Sep 24, 2024
37 checks passed
@CaselIT CaselIT deleted the finish_typing branch September 26, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestClient methods are typed to return _ResultBase, but actually return Result
2 participants