-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typing): TestClient methods return Result, not _ResultBase #2211
Conversation
Moved to draft for now, I'll look at the failure next week. @vytas7 I don't remember if we settled on installing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2211 +/- ##
===========================================
- Coverage 100.00% 99.94% -0.06%
===========================================
Files 62 62
Lines 6880 6919 +39
Branches 1099 1099
===========================================
+ Hits 6880 6915 +35
- Misses 0 4 +4 ☔ View full report in Codecov by Sentry. |
No, I'd love to keep the "production" installation of Falcon free of any dependencies. Is it possible to instruct the type checker to install these extensions? Also, it is probably OK to add these dependencies on older Python versions. We don't even ship Linux wheels for some of them. |
I don't think so. I'll try doing something more sophisticated wrt import |
@CaselIT has this PR been superseded by others in the typing work stream, or should we still consider this one separately? |
No, it's still relevant. I plan on finishing it once the other ones are merged |
replaced by #2338 |
Follow up of #2209 cc @davetapley
Fixes #2207