Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin tox to work around 3.21 bug #1850

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

kgriffs
Copy link
Member

@kgriffs kgriffs commented Jan 9, 2021

See also: tox-dev/tox#1777

@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #1850 (25670ff) into master (4dc65ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1850   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         5164      5164           
  Branches       833       833           
=========================================
  Hits          5164      5164           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc65ec...25670ff. Read the comment docs.

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided pinning instructions will result in tox version 3.20.0 getting used instead of the latest "good" 3.20.1. But OTOH the sole fix in 3.20.0 ➡️ 3.20.1 does not really affect us, so 👍 :shipit:

@vytas7 vytas7 merged commit 3596cd7 into falconry:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants