chore: pin tox to work around 3.21 bug

See also: tox-dev/tox#1777
falconry · Jan 9, 2021 · 419f549 · 419f549
1 parent 4dc65ec
commit 419f549
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/.github/workflows/create-wheels.yaml b/.github/workflows/create-wheels.yaml
@@ -65,7 +65,11 @@ jobs:
           FALCON_ASGI_WRAP_NON_COROUTINES: Y
           FALCON_TESTING_SESSION: Y
         run: |
-          pip install 'tox>=3.20'
+          # TODO(kgriffs): Revisit second half of 2021 to see if we still need to pin tox
+          #
+          #   See also: https://github.com/tox-dev/tox/issues/1777
+          #
+          pip install 'tox==3.20'
           tox -e wheel_check -- ${{ matrix.pytest-extra }}
 
       - name: Get wheel name
@@ -177,7 +181,7 @@ jobs:
           FALCON_ASGI_WRAP_NON_COROUTINES: Y
           FALCON_TESTING_SESSION: Y
         run: |
-          pip install 'tox>=3.20'
+          pip install 'tox==3.20'
           tox -e wheel_check -- ${{ matrix.pytest-extra }}
 
       - name: Get wheel names
@@ -353,7 +357,7 @@ jobs:
           args: |
             bash -c "
             export PATH=/opt/python/${{ matrix.python-version }}/bin:$PATH &&
-            pip install 'tox>=3.20' 'pip>=20' &&
+            pip install 'tox==3.20' 'pip>=20' &&
             tox -e wheel_check -- ${{ matrix.pytest-extra }}
             "
 
@@ -377,7 +381,7 @@ jobs:
           args: |
             bash -c "
             export PATH=/opt/python/${{ matrix.python-version }}/bin:$PATH &&
-            pip install 'tox>=3.20' 'pip>=20' &&
+            pip install 'tox==3.20' 'pip>=20' &&
             tox -e wheel_check -- ${{ matrix.pytest-extra }}
             "
 

diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -106,10 +106,14 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libunwind-dev
 
+      # TODO(kgriffs): Revisit second half of 2021 to see if we still need to pin tox
+      #
+      #   See also: https://github.com/tox-dev/tox/issues/1777
+      #
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install coverage tox
+          pip install coverage tox==3.20
           python --version
           pip --version
           tox --version

diff --git a/tools/mintest.sh b/tools/mintest.sh
@@ -1,6 +1,10 @@
 #!/usr/bin/env bash
 
-pip install -U tox coverage
+# TODO(kgriffs): Revisit second half of 2021 to see if we still need to pin tox
+#
+#   See also: https://github.com/tox-dev/tox/issues/1777
+#
+pip install -U tox==3.20 coverage
 
 rm -f .coverage.*