-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(date)!: separate timeZone method #2947
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2947 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2987 2989 +2
Lines 216052 216099 +47
Branches 954 598 -356
==========================================
+ Hits 215973 216004 +31
- Misses 79 95 +16
|
Why do you consider this breaking |
I'm not sure I do. It might not be ! Breaking but noteworthy for the migration guide nontheless. I think it could be considered breaking because it narrows the spec for location.timezone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a few time zones for a few "easy" locales just to check it works as expected?
IMO we can do that in one or more separate PRs. |
Could we add a test to check that all locale timezone definitions are subsets of the base list? |
082a882
Done |
Adds #735
Adds
faker.date.timeZone()
for a random global time zone.Narrows
faker.location.timeZone()
to a random locale specific time zone.