test: improve expectations

faker-js · Jun 20, 2024 · 4527b50 · 4527b50
1 parent 2ea1cfb
commit 4527b50
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/test/modules/date.spec.ts b/test/modules/date.spec.ts
@@ -667,7 +667,11 @@ describe('date', () => {
 
   describe('definitions', () => {
     describe('timeZone', () => {
-      // date.timezone data should only be available in the base locale
+      it('should have timezones in the base locale', () => {
+        expect(allLocales.base.date?.time_zone).toSatisfy(Array.isArray);
+        expect(allLocales.base.date?.time_zone?.length).toBeGreaterThan(0);
+      });
+
       it.each(
         Object.entries(allLocales).filter(([locale]) => locale !== 'base')
       )('should not have any timezones in %s', (_, data) => {

diff --git a/test/modules/location.spec.ts b/test/modules/location.spec.ts
@@ -413,13 +413,17 @@ describe('definitions', () => {
       'locale data for %s should be a subset of the base locale',
       (locale, data) => {
         if (locale === 'base') {
+          expect(data.location?.time_zone).toSatisfy(Array.isArray);
+          expect(data.location?.time_zone?.length).toBeGreaterThan(0);
           expect(data.location?.time_zone).toEqual(
             allLocales.base.date?.time_zone
           );
         } else if (data.location?.time_zone != null) {
+          expect(data.location.time_zone).toSatisfy(Array.isArray);
+          expect(data.location.time_zone.length).toBeGreaterThan(0);
           // expected and actual are flipped here
           expect(allLocales.base.date?.time_zone).toEqual(
-            expect.arrayContaining(data.location?.time_zone)
+            expect.arrayContaining(data.location.time_zone)
           );
         }
       }