-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(tsconfig): noImplicitAny #2562
Conversation
I'm really unhappy with typescripts behavior here and I hope this gets better in a future version. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2562 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 2805 2806 +1
Lines 250179 250192 +13
Branches 1106 1108 +2
==========================================
+ Hits 249122 249131 +9
- Misses 1029 1033 +4
Partials 28 28
|
Are you talking about We could make an internal helper function that is "correctly" typed: function keys<T extends {}>(obj: T): (keyof T)[] {
return Object.keys(obj) as (keyof T)[];
} That way, we only have to cast in one place. |
Fixes #1837