Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on noImplicitAny in tsconfig #1837

Closed
ST-DDT opened this issue Feb 13, 2023 · 1 comment · Fixed by #1839 or #2562
Closed

Turn on noImplicitAny in tsconfig #1837

ST-DDT opened this issue Feb 13, 2023 · 1 comment · Fixed by #1839 or #2562
Assignees
@ST-DDT @Shinigami92
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Feb 13, 2023 •
edited
Loading

#651 partially activated strict mode, this flag was omitted at that time and should probably be turned on.

faker/tsconfig.json

Line 15 in c46c539

// "noImplicitAny": true,

Related issues:
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Feb 13, 2023
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Feb 13, 2023
This was referenced Feb 13, 2023
Merged
Closed
Closed
Closed
Closed
@Shinigami92 Shinigami92 mentioned this issue Feb 14, 2023
Merged
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap Feb 14, 2023
@Shinigami92 Shinigami92 self-assigned this Feb 14, 2023
@Shinigami92 Shinigami92 moved this from In Progress to Awaiting Review in Faker Roadmap Feb 14, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Faker Roadmap Feb 15, 2023
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Nov 26, 2023 •
edited
Loading

This has been partially reintroduced in #2102.

@ST-DDT ST-DDT mentioned this issue Nov 28, 2023
Merged
@ST-DDT ST-DDT self-assigned this Nov 28, 2023
@ST-DDT ST-DDT modified the milestones: v8.x, vAnytime Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

@Shinigami92 Shinigami92

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

chore: activate noImplicitAny faker-js/faker
infra(tsconfig): noImplicitAny faker-js/faker
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox