Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename patterns to pattern #2059

Merged
merged 2 commits into from
Apr 17, 2023
Merged

refactor: rename patterns to pattern #2059

merged 2 commits into from
Apr 17, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 added the c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs label Apr 16, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 16, 2023 12:28
@Shinigami92 Shinigami92 self-assigned this Apr 16, 2023
@ST-DDT ST-DDT requested review from a team April 16, 2023 12:35
@codecov
Copy link

codecov bot commented Apr 16, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@4708011). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ee2fdb1 differs from pull request most recent head ff62b5b. Consider uploading reports for the commit ff62b5b to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2059   +/-   ##
=======================================
  Coverage        ?   99.61%           
=======================================
  Files           ?     2535           
  Lines           ?   241581           
  Branches        ?     1281           
=======================================
  Hits            ?   240647           
  Misses          ?      907           
  Partials        ?       27

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Apr 16, 2023
@Shinigami92 Shinigami92 mentioned this pull request Apr 16, 2023
Merged
@ST-DDT ST-DDT enabled auto-merge (squash) April 17, 2023 08:30
@ST-DDT ST-DDT merged commit b69c28e into next Apr 17, 2023
@ST-DDT ST-DDT deleted the rename-patterns-to-pattern branch April 17, 2023 08:37
@matthewmayer matthewmayer mentioned this pull request May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox