Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(locale): remove bs_ files in sk and cz #1942

Merged
merged 2 commits into from
Mar 19, 2023
Merged

chore(locale): remove bs_ files in sk and cz #1942

merged 2 commits into from
Mar 19, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #1916

@matthewmayer matthewmayer requested a review from a team as a code owner March 17, 2023 06:48
@matthewmayer matthewmayer marked this pull request as draft March 17, 2023 06:49
@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

Merging #1942 (426d8ee) into next (2fa095f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1942      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2358     2354       -4     
  Lines      236907   236555     -352     
  Branches     1230     1229       -1     
==========================================
- Hits       236038   235687     -351     
+ Misses        847      846       -1     
  Partials       22       22
Impacted Files Coverage Δ
src/locales/cz/company/index.ts 100.00% <ø> (ø)
src/locales/sk/company/index.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer marked this pull request as ready for review March 17, 2023 07:04
@matthewmayer matthewmayer self-assigned this Mar 17, 2023
Shinigami92
Shinigami92 reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that we actually want to delete these instead of rename them?

@matthewmayer
Copy link
Contributor Author

They are not in Slovak or Czech.

Shinigami92
Shinigami92 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see... I didn't opened the "Load diff" in the GitHub Web UI 🤦

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Mar 17, 2023
@ST-DDT ST-DDT requested review from a team March 17, 2023 21:38
@ST-DDT ST-DDT enabled auto-merge (squash) March 19, 2023 19:21
@ST-DDT ST-DDT merged commit 73035ef into faker-js:next Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

cz and sk still have bs_noun.ts files
4 participants
@matthewmayer @ST-DDT @Shinigami92 @xDivisionByZerox