Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cz and sk still have bs_noun.ts files #1916

Closed
matthewmayer opened this issue Mar 9, 2023 · 1 comment · Fixed by #1942
Closed

cz and sk still have bs_noun.ts files #1916

matthewmayer opened this issue Mar 9, 2023 · 1 comment · Fixed by #1942
Assignees
@matthewmayer
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@matthewmayer
Copy link
Contributor

Looks like in #1860 which renamed bs_noun etc to buzz_noun, the cz and sk lists didn't get renamed e.g.:
https://github.com/faker-js/faker/blob/next/src/locales/sk/company/bs_noun.ts

However given these are just copies of the English lists, probably best just to delete?
@ST-DDT
Copy link
Member

ST-DDT commented Mar 9, 2023

If these are just copies of the English list we should delete them.
Maybe do a general sweep and check/remove duplicates.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels Mar 9, 2023
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Mar 9, 2023
@matthewmayer matthewmayer mentioned this issue Mar 17, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Faker Roadmap Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

chore(locale): remove bs_ files in sk and cz matthewmayer/faker
2 participants
@matthewmayer @ST-DDT