Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locales): add mergeLocales utility #1707

Merged
merged 13 commits into from
Jan 13, 2023
Merged

feat(locales): add mergeLocales utility #1707

merged 13 commits into from
Jan 13, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 2, 2023

Part 1 of

This PR provides a method that merges multiple locales into a single one.

Future PRs will:

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels Jan 2, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Jan 2, 2023
@ST-DDT ST-DDT requested review from a team January 2, 2023 01:25
@ST-DDT ST-DDT self-assigned this Jan 2, 2023
src/utils/merge-locales.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #1707 (1dd8e63) into next (47b2cfc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1707   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2336     2337    +1     
  Lines      241141   241178   +37     
  Branches     1088     1098   +10     
=======================================
+ Hits       240257   240294   +37     
  Misses        863      863           
  Partials       21       21           
Impacted Files Coverage Δ
src/utils/merge-locales.ts 100.00% <100.00%> (ø)

src/utils/merge-locales.ts Outdated Show resolved Hide resolved
src/utils/merge-locales.ts Outdated Show resolved Hide resolved
src/utils/merge-locales.ts Outdated Show resolved Hide resolved
src/utils/merge-locales.ts Show resolved Hide resolved
test/utils/merge-locales.spec.ts Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team January 6, 2023 09:59
@ST-DDT ST-DDT requested a review from a team January 11, 2023 18:48
src/utils/merge-locales.ts Outdated Show resolved Hide resolved
test/utils/merge-locales.spec.ts Show resolved Hide resolved
@ST-DDT ST-DDT requested review from Shinigami92 and a team January 11, 2023 21:35
@ST-DDT ST-DDT merged commit 788fce0 into next Jan 13, 2023
@ST-DDT ST-DDT deleted the feat/locales/merge branch January 13, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants