-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locales): add mergeLocales utility #1707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: feature
Request for new feature
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
c: locale
Permutes locale definitions
labels
Jan 2, 2023
ST-DDT
commented
Jan 2, 2023
ST-DDT
commented
Jan 2, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1707 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2336 2337 +1
Lines 241141 241178 +37
Branches 1088 1098 +10
=======================================
+ Hits 240257 240294 +37
Misses 863 863
Partials 21 21
|
Shinigami92
reviewed
Jan 2, 2023
Co-authored-by: Shinigami <[email protected]>
xDivisionByZerox
previously approved these changes
Jan 10, 2023
Shinigami92
reviewed
Jan 11, 2023
Shinigami92
reviewed
Jan 11, 2023
Shinigami92
approved these changes
Jan 11, 2023
xDivisionByZerox
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: feature
Request for new feature
c: locale
Permutes locale definitions
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of
This PR provides a method that merges multiple locales into a single one.
Future PRs will:
Faker
class (Remove locale switching support #1340)