chore: edit after review

faker-js · Jan 11, 2023 · 4f091cc · 4f091cc
1 parent a0d2616
commit 4f091cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/utils/merge-locales.ts b/src/utils/merge-locales.ts
@@ -27,7 +27,7 @@ export function mergeLocales(locales: LocaleDefinition[]): LocaleDefinition {
         if (typeof locale[key] === 'object') {
           merged[key] = { ...locale[key], ...merged[key] };
         } else {
-          // Do nothing
+          // Primitive values cannot be not merged
         }
       }
     }

diff --git a/test/utils/merge-locales.spec.ts b/test/utils/merge-locales.spec.ts
@@ -3,7 +3,7 @@ import type { LocaleDefinition } from '../../src';
 import { mergeLocales } from '../../src/utils/merge-locales';
 
 describe('mergeLocales', () => {
-  it('should overwrite locales', () => {
+  it('should not overwrite entries', () => {
     const locale1: LocaleDefinition = {
       title: 'a',
       person: { firstName: ['a'] },
@@ -29,7 +29,7 @@ describe('mergeLocales', () => {
     });
   });
 
-  it('should extend locales', () => {
+  it('should extend categories', () => {
     const locale1: LocaleDefinition = {
       title: 'a',
       location: { city: ['a'] },