Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: update website redirects (v7) #1522

Merged
merged 1 commit into from
Nov 10, 2022
Merged

infra: update website redirects (v7) #1522

merged 1 commit into from
Nov 10, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 5, 2022

Based on an idea proposed by @matthewmayer in #1517 (comment).

This PR ensures that

  • our chat and demo page can be accessed in a symmetric way
  • we can already use the v7+v8 domains as redirects to the main and next page respectively

This PR does point to main website.

Next Branch PR: #1523

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Nov 5, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Nov 5, 2022
@ST-DDT ST-DDT requested review from a team November 5, 2022 11:57
@ST-DDT ST-DDT self-assigned this Nov 5, 2022
@ST-DDT ST-DDT changed the base branch from next to v7 November 5, 2022 12:00
@Shinigami92
Copy link
Member

What happens if a sub-domain collides with one of the branch-sub-domains configured by Netlify?
Which would take precedence?

@Shinigami92
Copy link
Member

Looks like I can merge this right now without giving a review by another maintainer 👀
I think we need to configure these branches also as protected with more restrictions

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 7, 2022

What happens if a sub-domain collides with one of the branch-sub-domains configured by Netlify? Which would take precedence?

The configuration from the prod branch. It is set to force so it will even take effect if there is a page to display.

@ST-DDT ST-DDT merged commit f75b540 into v7 Nov 10, 2022
@ST-DDT ST-DDT deleted the infra/website-redirects-v7 branch November 10, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants